Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: unlock all steps in space creation #1172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: unlock all steps in space creation #1172

wants to merge 3 commits into from

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Feb 10, 2025 •
edited
Loading

Summary

Toward https://github.com/snapshot-labs/workflow/issues/437

This PR will unlock navigation to all steps, in the space creation form, instead users to move to any steps, even if the previous one is invalid

How to test

  1. Go to onchain or offchain space creation
  2. You can navigate to any steps
  3. The step valid status is marked in the navigation menu

@wa0x6e wa0x6e marked this pull request as ready for review February 10, 2025 17:40
@wa0x6e wa0x6e requested a review from bonustrack February 10, 2025 17:41
@bonustrack
Copy link
Member

Looks good.

  • Can you use link color for the menu items?
  • Can we force login only in the ENS name step and move that step after "Profile"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bonustrack bonustrack Awaiting requested review from bonustrack

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @bonustrack