apply suggestions from code review

Author: sfc-gh-osalazarlizano

.github/workflows/ci-integration.yml

@@ -34,7 +34,7 @@ jobs:
         id: modified-apps-step
         uses: ./.github/actions/modified_apps
       - name: Set up Snowflake CLI
-        uses: Snowflake-Labs/snowflake-cli-action@v1
+        uses: Snowflake-Labs/snowflake-cli-action@v1.1
         with:
           cli-version: "latest"
           default-config-file-path: "config.toml"
@@ -49,11 +49,8 @@ jobs:
             IFS=',' read -ra modified_apps_array <<< "$modified_apps"
             for app in "${modified_apps_array[@]}"; do
                 cd $app
-                if [ -f ci.json ]; then 
-                    commands=$(jq -r '.commands[]' ci.json)
-                    for command in "${commands[@]}"; do
-                        eval "$command"
-                    done
+                if [ -f ci.sh ]; then 
+                    sh ci.sh
                 else
                    snow app run
                    snow app teardown

.github/workflows/ci.yml

@@ -43,7 +43,7 @@ jobs:
             const { MODIFIED_APPS } = process.env;
             const fs = require('fs');
             const path = require('path');
-            var has_tests = false;
+            var has_python_tests = false;
 
             function getPytestPaths(dir, callback) 
             {
@@ -59,13 +59,8 @@ jobs:
                   extension = path.extname(file.name);
 
                   if (extension == '.py')
-                  {
-                    if (file.name.startsWith('test'))
-                    {
-                      has_tests = true
-                    }
-                    
-                    callback(dir);
+                  {                    
+                    callback(dir, file.name);
                   }
                 }
               }
@@ -78,9 +73,15 @@ jobs:
             for (const rootPath of paths) 
             { 
               let subFoldersWithPythonFiles = 0;
-              getPytestPaths(rootPath, x => 
+              getPytestPaths(rootPath, (folder, fileName) => 
               {
-                pytestPaths.add(x);
+                pytestPaths.add(folder);
+                
+                if (fileName.startsWith('test'))
+                {
+                  has_python_tests = true
+                }
+
                 subFoldersWithPythonFiles++
               })
 

account-privileges/ci.json

@@ -0,0 +1,3 @@
+snow sql -f 'prepare/references.sql'
+snow app run
+snow app teardown

account-privileges/ci.sh

@@ -0,0 +1,3 @@
+sh prepare_data.sh
+snow app run
+snow app teardown

data-mapping/ci.json

@@ -0,0 +1,3 @@
+snow sql -f 'prepare/provider.sql'
+snow app run
+snow app teardown

data-mapping/ci.sh

@@ -0,0 +1,3 @@
+sh setup.sh
+sh deploy.sh
+sh cleanup.sh