Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snow 1634717 configuration layer #892

Merged
merged 6 commits into from
Sep 9, 2024

Conversation

sfc-gh-fpawlowski
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski commented Aug 22, 2024

Description

Implemented logging for configuration layer.

Checklist

  • Format code according to the existing code style (run npm run lint:check -- CHANGED_FILES and fix problems in changed code)
  • Create tests which fail without the change (if possible)
  • Make all tests (unit and integration) pass (npm run test:unit and npm run test:integration)
  • Extend the README / documentation and ensure is properly displayed (if necessary)
  • Provide JIRA issue id (if possible) or GitHub issue id in commit message

@sfc-gh-fpawlowski sfc-gh-fpawlowski requested a review from a team as a code owner August 22, 2024 14:16
Copy link

github-actions bot commented Aug 22, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-fpawlowski sfc-gh-fpawlowski changed the base branch from master to SNOW-1017607-Improve-logging-Node.js-driver August 22, 2024 14:19
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.75%. Comparing base (b608860) to head (7a63ae1).

Files with missing lines Patch % Lines
lib/configuration/client_configuration.js 91.89% 3 Missing ⚠️
lib/configuration/connection_configuration.js 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
- Coverage   88.95%   88.75%   -0.21%     
==========================================
  Files          65       65              
  Lines        6267     6304      +37     
==========================================
+ Hits         5575     5595      +20     
- Misses        692      709      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lib/configuration/client_configuration.js Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/connection_configuration.js Outdated Show resolved Hide resolved
@sfc-gh-fpawlowski
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
lib/configuration/connection_configuration.js Outdated Show resolved Hide resolved
lib/configuration/client_configuration.js Outdated Show resolved Hide resolved
@sfc-gh-fpawlowski sfc-gh-fpawlowski changed the base branch from SNOW-1017607-Improve-logging-Node.js-driver to master August 29, 2024 11:42
@sfc-gh-fpawlowski sfc-gh-fpawlowski merged commit a33f997 into master Sep 9, 2024
49 of 50 checks passed
@sfc-gh-fpawlowski sfc-gh-fpawlowski deleted the SNOW-1634717-Configuration-Layer branch September 9, 2024 17:36
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants