-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for Vectorized Scanner in write_pandas #2164
base: main
Are you sure you want to change the base?
Add ability for Vectorized Scanner in write_pandas #2164
Conversation
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
dfaada9
to
24ff852
Compare
Hey @sfc-gh-dszmolka I was wondering how long does an initial review typically take? |
i really cannot comment on it, as i do not own the resources who are responsible for reviewing the PRs. I'm very sorry to hear it's not fast enough, but also don't have any advice at this point besides hoping the team eventually gets there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code/feature looks good to me, but I no longer own the Python connector. I'll add some reviewers to move the review forward though
@@ -534,6 +575,7 @@ def test_table_location_building( | |||
|
|||
def mocked_execute(*args, **kwargs): | |||
if len(args) >= 1 and args[0].startswith("COPY INTO"): | |||
print(kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debug print? Let's remove it?
print(kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe so, that wasn't apart of my changes. Don't want to change other people's stuff but that is what it looked like to me.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1903333: Add ability for USE_VECTORIZED_SCANNER in write_pandas #2157
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
USE_VECTORIZED_SCANNER
parameter in the functionwrite_pandas
when running the SQL commandCOPY INTO