Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for Vectorized Scanner in write_pandas #2164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

culpgrant
Copy link

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1903333: Add ability for USE_VECTORIZED_SCANNER in write_pandas #2157

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

  • Give the user to specify the USE_VECTORIZED_SCANNER parameter in the function write_pandas when running the SQL command COPY INTO
  1. (Optional) PR for stored-proc connector:

Copy link

github-actions bot commented Feb 3, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@culpgrant
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@culpgrant culpgrant force-pushed the feature/pandas_tools_vectorized_scanner branch from dfaada9 to 24ff852 Compare February 3, 2025 04:12
@sfc-gh-dszmolka sfc-gh-dszmolka requested review from a team February 3, 2025 09:54
@culpgrant
Copy link
Author

Hey @sfc-gh-dszmolka I was wondering how long does an initial review typically take?

@sfc-gh-dszmolka
Copy link
Contributor

i really cannot comment on it, as i do not own the resources who are responsible for reviewing the PRs. I'm very sorry to hear it's not fast enough, but also don't have any advice at this point besides hoping the team eventually gets there.

Copy link
Collaborator

@sfc-gh-mkeller sfc-gh-mkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code/feature looks good to me, but I no longer own the Python connector. I'll add some reviewers to move the review forward though

@@ -534,6 +575,7 @@ def test_table_location_building(

def mocked_execute(*args, **kwargs):
if len(args) >= 1 and args[0].startswith("COPY INTO"):
print(kwargs)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug print? Let's remove it?

Suggested change
print(kwargs)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe so, that wasn't apart of my changes. Don't want to change other people's stuff but that is what it looked like to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNOW-1903333: Add ability for USE_VECTORIZED_SCANNER in write_pandas
3 participants