Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1915469 Basic support for DECFLOAT type #2167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

SNOW-1915469 Basic support for DECFLOAT type #2167

wants to merge 1 commit into from
+218 −0

Conversation

sfc-gh-tkissinger
Copy link

@sfc-gh-tkissinger sfc-gh-tkissinger commented Feb 6, 2025 •
edited by jira bot
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Implements SNOW-1915469

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    This PR adds basic decimal float (DECFLOAT) data type support to the python connector.

  • Supports ARROW and JSON result format. DECFLOATs are converted to Decimal or numpy.float64
  • Server-side binding support using explicit Snowflake type specification as Decimal is already mapped to FIXED by default
  • No Pandas support
  1. (Optional) PR for stored-proc connector:

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 6, 2025 •
edited
Loading

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-tkissinger sfc-gh-tkissinger self-assigned this Feb 6, 2025
@sfc-gh-tkissinger sfc-gh-tkissinger force-pushed the tkissinger-SNOW-1915469-basic-decfloat-support branch from bd85ab5 to ec1ed48 Compare February 6, 2025 16:48
@sfc-gh-tkissinger
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-tkissinger sfc-gh-tkissinger force-pushed the tkissinger-SNOW-1915469-basic-decfloat-support branch from ec1ed48 to 7ee6e0d Compare February 6, 2025 17:01
@sfc-gh-tkissinger
SNOW-1915469 Basic support for DECFLOAT type
be9baa7 
Description
Adds basic support for the DECFLOAT data type
- query results in JSON and ARROW format: Maps to Decimal or
  numpy.float64
- bindings: for qmark style bindings, the type needs to be explicitly
  specified
@sfc-gh-tkissinger sfc-gh-tkissinger force-pushed the tkissinger-SNOW-1915469-basic-decfloat-support branch from 7ee6e0d to be9baa7 Compare February 16, 2025 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mkeller sfc-gh-mkeller Awaiting requested review from sfc-gh-mkeller

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose

@sfc-gh-pfus sfc-gh-pfus Awaiting requested review from sfc-gh-pfus

At least 1 approving review is required to merge this pull request.

Assignees

@sfc-gh-tkissinger sfc-gh-tkissinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-tkissinger @sfc-gh-pfus