Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1374896: return toString result for getObject called on structured types #1945

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

SNOW-1374896: return toString result for getObject called on structured types #1945

wants to merge 12 commits into from
+219 −65

Conversation

sfc-gh-mkubik
Copy link
Contributor

@sfc-gh-mkubik sfc-gh-mkubik commented Oct 29, 2024 •
edited
Loading

SNOW-1374896

Turns out that backward compatibility with JSON structured types may also require support for getObject and getBytes methods.
This PR adds JSON/ARROW compatibility for getObject

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-mkubik sfc-gh-mkubik changed the title SNOW-1374896: return toString result for getObject and getBytes called on structured types SNOW-1374896: return toString result for getObject called on structured types Oct 30, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki marked this pull request as ready for review October 30, 2024 09:48
@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner October 30, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mkubik @sfc-gh-dprzybysz @sfc-gh-pmotacki