Skip to content

SNOW-2408336 Allow dots and hyphens in oauth url #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SNOW-2408336 Allow dots and hyphens in oauth url #1190

wants to merge 1 commit into from

Conversation

sfc-gh-wtrefon
Copy link
Contributor

Overview

SNOW-2408336

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

@sfc-gh-wtrefon sfc-gh-wtrefon requested a review from a team as a code owner October 17, 2025 07:56
sfc-gh-wtrefon
sfc-gh-wtrefon commented Oct 17, 2025
View reviewed changes
src/main/java/com/snowflake/kafka/connector/internal/SnowflakeErrors.java
+ " to 'https://'. Port defaults to 443 for https and 80 for http. Path may contain"
+ " alphanumeric characters, dots, hyphens, and forward slashes (e.g.,"
+ " 'login.example.com/oauth2/v2.0/token')."),
ERROR_0034(
Copy link
Contributor Author

@sfc-gh-wtrefon sfc-gh-wtrefon Oct 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one hasn't been used yet so i moved it from 0033 -> 0034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sfc-gh-mbobowski sfc-gh-mbobowski sfc-gh-mbobowski approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sfc-gh-wtrefon @sfc-gh-mbobowski