Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Private rebalance & Closing issue jar #685

Closed
wants to merge 5 commits into from

Conversation

sfc-gh-japatel
Copy link
Collaborator

Continue on #682
with one more commit!

@sfc-gh-japatel sfc-gh-japatel changed the title [DNM] Pr 682 local [DNM] Private rebalance & Closing issue jar Aug 5, 2023
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #685 (92e2c5a) into rcheng-v1.9.4 (0f570ee) will decrease coverage by 1.29%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           rcheng-v1.9.4     #685      +/-   ##
=================================================
- Coverage          87.97%   86.69%   -1.29%     
=================================================
  Files                 50       50              
  Lines               4143     4141       -2     
  Branches             451      450       -1     
=================================================
- Hits                3645     3590      -55     
- Misses               330      385      +55     
+ Partials             168      166       -2     
Files Changed Coverage Δ
...m/snowflake/kafka/connector/SnowflakeSinkTask.java 72.19% <100.00%> (ø)
...tor/internal/streaming/SnowflakeSinkServiceV2.java 80.86% <100.00%> (ø)
...ctor/internal/streaming/TopicPartitionChannel.java 91.58% <100.00%> (+0.19%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@sfc-gh-rcheng sfc-gh-rcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - failing the aws e2e tests though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants