-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer ownership of project in CODEOWNERS file. Change streaming-ingest to snowpipe kafka team #842
Transfer ownership of project in CODEOWNERS file. Change streaming-ingest to snowpipe kafka team #842
Conversation
…gest to snowpipe kafka team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Should we wait until end of this month or you believe the team is ready as of today? This means that we won't have any PR request unless being added explicitly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels like a very monumental pr, lgtm!
@sfc-gh-tzhang the team feels confident about it. I talked with @sfc-gh-psaraiya - I will merge this PR after the May Kafka Connector release. |
Thanks for confirming, we just had a release done a few days ago if that's what you mean by May release |
…gest to snowpipe kafka team (snowflakedb#842)
Overview
NO-SNOW
As a part of project handoff, we need to change CODEOWNERS. My team feels confident that we can take over full ownership.
Pre-review checklist
snowflake.ingestion.method
.Yes
- Added end to end and Unit Tests.No
- Suggest why it is not param protected