Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership of project in CODEOWNERS file. Change streaming-ingest to snowpipe kafka team #842

Merged
merged 1 commit into from
May 15, 2024

Conversation

sfc-gh-nsienkiewicz-1
Copy link
Contributor

Overview

NO-SNOW

As a part of project handoff, we need to change CODEOWNERS. My team feels confident that we can take over full ownership.

Pre-review checklist

  • This change should be part of a Behavior Change Release. See go/behavior-change.
  • This change has passed Merge gate tests
  • Snowpipe Changes
  • Snowpipe Streaming Changes
  • This change is TEST-ONLY
  • This change is README/Javadocs only
  • This change is protected by a config parameter <PARAMETER_NAME> eg snowflake.ingestion.method.
    • Yes - Added end to end and Unit Tests.
    • No - Suggest why it is not param protected
  • Is his change protected by parameter <PARAMETER_NAME> on the server side?
    • The parameter/feature is not yet active in production (partial rollout or PrPr, see Changes for Unreleased Features and Fixes).
    • If there is an issue, it can be safely mitigated by turning the parameter off. This is also verified by a test (See go/ppp).

Copy link
Collaborator

@sfc-gh-japatel sfc-gh-japatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sfc-gh-tzhang
Copy link
Contributor

As a part of project handoff, we need to change CODEOWNERS. My team feels confident that we can take over full ownership.

Should we wait until end of this month or you believe the team is ready as of today? This means that we won't have any PR request unless being added explicitly.

Copy link
Collaborator

@sfc-gh-rcheng sfc-gh-rcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels like a very monumental pr, lgtm!

@sfc-gh-nsienkiewicz-1
Copy link
Contributor Author

sfc-gh-nsienkiewicz-1 commented May 10, 2024

Should we wait until end of this month or you believe the team is ready as of today? This means that we won't have any PR request unless being added explicitly.

@sfc-gh-tzhang the team feels confident about it. I talked with @sfc-gh-psaraiya - I will merge this PR after the May Kafka Connector release.

@sfc-gh-tzhang
Copy link
Contributor

Should we wait until end of this month or you believe the team is ready as of today? This means that we won't have any PR request unless being added explicitly.

@sfc-gh-tzhang the team feels confident about it. I talked with @sfc-gh-psaraiya - I will merge this PR after the May Kafka Connector release.

Thanks for confirming, we just had a release done a few days ago if that's what you mean by May release

@sfc-gh-nsienkiewicz-1 sfc-gh-nsienkiewicz-1 merged commit 5452d29 into master May 15, 2024
81 checks passed
@sfc-gh-nsienkiewicz-1 sfc-gh-nsienkiewicz-1 deleted the nsienkiewicz-codeowners-transfer branch May 15, 2024 08:56
ConfluentSemaphore pushed a commit to confluentinc/snowflake-kafka-connector that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants