Skip to content

NOSNOW: improve troubleshooting experience for scenario with skipped offsets #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2024
Merged

NOSNOW: improve troubleshooting experience for scenario with skipped offsets #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .../java/com/snowflake/kafka/connector/internal/streaming/BufferedTopicPartitionChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,13 @@ public void insertRecord(SinkRecord kafkaSinkRecord, boolean isFirstRowPerPartit
insertRecords(copiedStreamingBuffer);
}
} else {
LOGGER.debug(
"Skip adding offset:{} to buffer for channel:{} because"
+ " offsetPersistedInSnowflake:{}, processedOffset:{}",
kafkaSinkRecord.kafkaOffset(),
LOGGER.warn(
"Channel {} - skipping current record - expected offset {} but received {}. The current"
+ " offset stored in Snowflake: {}",
this.getChannelNameFormatV1(),
currentOffsetPersistedInSnowflake,
currentProcessedOffset);
currentProcessedOffset,
kafkaSinkRecord.kafkaOffset(),
currentOffsetPersistedInSnowflake);
}
}

Expand Down
12 changes: 6 additions & 6 deletions ...in/java/com/snowflake/kafka/connector/internal/streaming/DirectTopicPartitionChannel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,13 @@ public void insertRecord(SinkRecord kafkaSinkRecord, boolean isFirstRowPerPartit
|| kafkaSinkRecord.kafkaOffset() >= currentProcessedOffset + 1) {
transformAndSend(kafkaSinkRecord);
} else {
LOGGER.debug(
"Skip adding offset:{} to buffer for channel:{} because"
+ " offsetPersistedInSnowflake:{}, processedOffset:{}",
kafkaSinkRecord.kafkaOffset(),
LOGGER.warn(
"Channel {} - skipping current record - expected offset {} but received {}. The current"
+ " offset stored in Snowflake: {}",
this.getChannelNameFormatV1(),
currentOffsetPersistedInSnowflake,
currentProcessedOffset);
currentProcessedOffset,
kafkaSinkRecord.kafkaOffset(),
currentOffsetPersistedInSnowflake);
}
}

Expand Down