Remove insertRows DEBUG log (called once per row) #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-lshcharbaty
approved these changes
Jul 22, 2024
airlock-confluentinc bot
pushed a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Aug 22, 2024
(cherry picked from commit 363457d)
sangeet259
added a commit
to confluentinc/snowflake-kafka-connector
that referenced
this pull request
Aug 22, 2024
* NOSNOW: added utility to upload connector to our nexus for simplified k8s deployment (snowflakedb#874) (cherry picked from commit ee83e22) * SNOW-1514185: Do assign the reopened channel unless kafka offsets are fully reset (snowflakedb#875) (cherry picked from commit 05dcbdf) * SNOW-1061851: Run SnowflakeSinkServiceV2IT for a single buffer (snowflakedb#876) (cherry picked from commit 7fce0f5) * SNOW-1061855 Fix the E2E test for SchemaEvolutionDropTable with a single buffer (snowflakedb#882) (cherry picked from commit fbd15d6) * NOSNOW: improve troubleshooting experience for scenario with skipped offsets (snowflakedb#883) (cherry picked from commit 7172481) * Adding logs to track schematization (snowflakedb#884) (cherry picked from commit 9905c7f) * Remove insertRows DEBUG log (called once per row) (snowflakedb#886) (cherry picked from commit 363457d) * NO-SNOW Upgrade nexus-staging-maven-plugin version (snowflakedb#887) (cherry picked from commit ac1276e) * Upgrade com.google.protobuf to 3.24.4 (snowflakedb#892) (cherry picked from commit 3c7e18c) * SNOW-1229110 Add single buffer usage data to telemetry (snowflakedb#893) (cherry picked from commit 96d3bfa) * SNOW-1541942 Extend Snowpipe initialization logging at INFO level (snowflakedb#885) (cherry picked from commit eab4c9c) * SNOW-947731 Remove deprecated avro-python3 package (snowflakedb#889) (cherry picked from commit 47624f5) * Bump dev.failsafe:failsafe from 3.2.1 to 3.3.2 (snowflakedb#859) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michał Bobowski <[email protected]> (cherry picked from commit 4a22f56) * Bump org.assertj:assertj-core from 3.25.3 to 3.26.3 (snowflakedb#881) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michał Bobowski <[email protected]> (cherry picked from commit adb896c) * Bump io.dropwizard.metrics:metrics-core from 4.2.3 to 4.2.26 (snowflakedb#863) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michał Bobowski <[email protected]> (cherry picked from commit 258ed2d) * NO-SNOW Ignore OAuth test (snowflakedb#906) (cherry picked from commit 30d2e8b) * SNOW-1229108 Add warning about buffer config when single buffer enabled (snowflakedb#896) (cherry picked from commit 9aa0b0b) * NO_SNOW Update dependencies (snowflakedb#898) Co-authored-by: Michał Bobowski <[email protected]> (cherry picked from commit eff23e2) * SNOW-1618257 - upgrade to 2.2.0 ingest-sdk (snowflakedb#910) (cherry picked from commit d0e97fb) * NO-SNOW Release v.2.4.0 (snowflakedb#907) Co-authored-by: Xin Huang <[email protected]> (cherry picked from commit 05c1148) --------- Co-authored-by: Greg Jachimko <[email protected]> Co-authored-by: Adrian Kowalczyk <[email protected]> Co-authored-by: Michał Bobowski <[email protected]> Co-authored-by: Xin Huang <[email protected]> Co-authored-by: Wojciech Trefon <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During performance tests I noticed huge amount of logs (15 times bigger than double buffer) being generated by this DEBUG level statement. We cannot afford it.