Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1324105-dependency-pinning: move versions pinning from project env to metadata #486

Merged
merged 3 commits into from
Apr 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,34 @@ jobs:
- name: Run lint checks
run: hatch run check

build-install:
name: Test package build and installation
runs-on: ubuntu-latest
needs: lint
steps:
- uses: actions/checkout@v4
with:
persist-credentials: false
- name: Setup up Python
uses: actions/setup-python@v5
with:
python-version: '3.8'
- name: Upgrade and install tools
run: |
python -m pip install -U pip
python -m pip install -U hatch
- name: Build package
run: |
python -m hatch clean
python -m hatch build
- name: Install and check import
run: |
python -m pip install dist/snowflake_sqlalchemy-*.whl
python -c "import snowflake.sqlalchemy; print(snowflake.sqlalchemy.__version__)"

test-dialect:
name: Test dialect ${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
needs: lint
needs: [ lint, build-install ]
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -93,7 +118,7 @@ jobs:

test-dialect-compatibility:
name: Test dialect compatibility ${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
needs: lint
needs: [ lint, build-install ]
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down Expand Up @@ -139,7 +164,7 @@ jobs:

test-dialect-run-v20:
name: Test dialect run v20 ${{ matrix.os }}-${{ matrix.python-version }}-${{ matrix.cloud-provider }}
needs: lint
needs: [ lint, build-install ]
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down
4 changes: 4 additions & 0 deletions DESCRIPTION.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Source code is also available at:

# Release Notes

- v1.5.3(Unrelased)

- Limit SQLAlchemy to < 2.0.0 before releasing version compatible with 2.0

- v1.5.2(April 11, 2024)

- Bump min SQLAlchemy to 1.4.19 for outer lateral join
Expand Down
7 changes: 1 addition & 6 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ classifiers = [
"Topic :: Software Development :: Libraries :: Application Frameworks",
"Topic :: Software Development :: Libraries :: Python Modules",
]
dependencies = ["snowflake-connector-python", "SQLAlchemy"]
dependencies = ["snowflake-connector-python<4.0.0", "SQLAlchemy>=1.4.19,<2.0.0"]

[tool.hatch.version]
path = "src/snowflake/sqlalchemy/version.py"
Expand Down Expand Up @@ -73,14 +73,9 @@ exclude = ["/.github"]
packages = ["src/snowflake"]

[tool.hatch.envs.default]
extra-dependencies = ["SQLAlchemy<2.0.0,>=1.4.19"]
features = ["development", "pandas"]
python = "3.8"

[tool.hatch.envs.sa20]
extra-dependencies = ["SQLAlchemy>=2.0.0"]
python = "3.8"

[tool.hatch.envs.default.env-vars]
COVERAGE_FILE = "coverage.xml"
SQLACHEMY_WARN_20 = "1"
Expand Down
2 changes: 1 addition & 1 deletion src/snowflake/sqlalchemy/version.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
#
# Update this for the versions
# Don't change the forth version number from None
VERSION = "1.5.2"
VERSION = "1.5.3"
Loading