Stop SQLAlchemy warnings about registering 'flatten' twice#521
Closed
saulbein wants to merge 1 commit intosnowflakedb:mainfrom
Closed
Stop SQLAlchemy warnings about registering 'flatten' twice#521saulbein wants to merge 1 commit intosnowflakedb:mainfrom
saulbein wants to merge 1 commit intosnowflakedb:mainfrom
Conversation
|
I am also getting this warning. Can someone from this snowflake team please review and merge this? |
|
Hello, I am getting this warning as well. Can someone please review and merge this? |
Contributor
|
i see another PR going (#532) which is also already merged and awaiting release, which hopefully helps with the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What issue is this PR addressing?
When loading
snowflake-sqlalchemy==1.6.1a warning is emitted about theflattenfunction being registered multiple times. It causes confusion as it's we had to check that our code wasn't overriding the function, while in reality it'ssnowflake-sqlalchemyregistering it twice.Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
As noted in SQLAlchemy documentation:
Which in this case means that current code is registering the function twice - once on class import time and another by explicitly calling
register_function. This PR removes the explicit registration and pushes the class import to be executed immediately when importing the library.