Skip to content

Commit

Permalink
SNOW-1752856: Implement DataFrame/Series align for axis = 1 and None (#…
Browse files Browse the repository at this point in the history
…2541)

<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-1752856

2. Fill out the following pre-review checklist:

- [x] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://docs.google.com/document/d/162d_i4zZ2AfcGRXojj0jByt8EUq-DrSHPPnTa4QvwbA/edit#bookmark=id.e82u4nekq80k)

3. Please describe how your code solves the related issue.

 Adding support for DataFrame/Series align for axis = 1 and None.

---------

Signed-off-by: Labanya Mukhopadhyay <[email protected]>
  • Loading branch information
sfc-gh-lmukhopadhyay authored Nov 15, 2024
1 parent f183a47 commit 5af35c5
Show file tree
Hide file tree
Showing 9 changed files with 848 additions and 211 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@

#### New Features

- Added support for `DataFrame.align` and `Series.align` for `axis=1` and `axis=None`.

#### Bug Fixes

Expand Down
4 changes: 2 additions & 2 deletions docs/source/modin/supported/dataframe_supported.rst
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ Methods
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
| ``align`` | P | ``copy``, ``level``, | ``N`` for MultiIndex, for deprecated parameters |
| | | ``fill_value`` | ``method``, ``limit``, ``fill_axis``, |
| | | | ``broadcast_axis``, if ``axis`` == 1 or None, or |
| | | | if ``fill_value`` is not default of np.nan |
| | | | ``broadcast_axis``, or if ``fill_value`` is not |
| | | | default of np.nan |
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
| ``all`` | P | | ``N`` for non-integer/boolean types |
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
Expand Down
4 changes: 2 additions & 2 deletions docs/source/modin/supported/series_supported.rst
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ Methods
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
| ``align`` | P | ``copy``, ``level``, | ``N`` for MultiIndex, for deprecated parameters |
| | | ``fill_value`` | ``method``, ``limit``, ``fill_axis``, |
| | | | ``broadcast_axis``, if ``axis`` == 1 or None, or |
| | | | if ``fill_value`` is not default of np.nan |
| | | | ``broadcast_axis``, or if ``fill_value`` is not |
| | | | default of np.nan |
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
| ``all`` | P | | ``N`` for non-integer/boolean types |
+-----------------------------+---------------------------------+----------------------------------+----------------------------------------------------+
Expand Down
Loading

0 comments on commit 5af35c5

Please sign in to comment.