Skip to content

Commit

Permalink
Add changes
Browse files Browse the repository at this point in the history
  • Loading branch information
sfc-gh-stan committed Nov 18, 2024
1 parent 8976902 commit a0b35bd
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 6 deletions.
26 changes: 23 additions & 3 deletions .github/workflows/precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,16 @@ jobs:
fail-fast: false
matrix:
os: [macos-latest, windows-latest-64-cores, ubuntu-latest-64-cores]
python-version: ["3.9", "3.10", "3.11"]
python-version: ["3.9", "3.10", "3.11", "3.12"]
cloud-provider: [aws, gcp, azure]
exclude:
# only run macos with aws py3.9 for doctest
- os: macos-latest
python-version: "3.10"
- os: macos-latest
python-version: "3.11"
- os: macos-latest
python-version: "3.12"
- os: macos-latest
python-version: "3.9"
cloud-provider: azure
Expand All @@ -111,6 +113,8 @@ jobs:
# only run ubuntu with py3.9 on aws and py3.10 on azure
- os: ubuntu-latest-64-cores
python-version: "3.11"
- os: ubuntu-latest-64-cores
python-version: "3.12"
- os: ubuntu-latest-64-cores
python-version: "3.9"
cloud-provider: azure
Expand All @@ -134,6 +138,12 @@ jobs:
- os: windows-latest-64-cores
python-version: "3.11"
cloud-provider: azure
- os: windows-latest-64-cores
python-version: "3.12"
cloud-provider: aws
- os: windows-latest-64-cores
python-version: "3.12"
cloud-provider: azure
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down Expand Up @@ -211,7 +221,7 @@ jobs:
fail-fast: false
matrix:
os: [macos-latest, windows-latest, ubuntu-latest]
python-version: [ "3.8", "3.9", "3.10", "3.11" ]
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12"]
cloud-provider: [aws]
steps:
- name: Checkout Code
Expand Down Expand Up @@ -341,14 +351,16 @@ jobs:
fail-fast: false
matrix:
os: [macos-latest, windows-latest-64-cores, ubuntu-latest-64-cores]
python-version: [ "3.9", "3.10", "3.11" ]
python-version: [ "3.9", "3.10", "3.11", "3.12"]
cloud-provider: [aws, gcp, azure]
exclude:
# only run macos with aws py3.9 for doctest
- os: macos-latest
python-version: "3.10"
- os: macos-latest
python-version: "3.11"
- os: macos-latest
python-version: "3.12"
- os: macos-latest
python-version: "3.9"
cloud-provider: azure
Expand All @@ -358,6 +370,8 @@ jobs:
# only run ubuntu with py3.9 on aws and py3.10 on azure
- os: ubuntu-latest-64-cores
python-version: "3.11"
- os: ubuntu-latest-64-cores
python-version: "3.12"
- os: ubuntu-latest-64-cores
python-version: "3.9"
cloud-provider: azure
Expand All @@ -381,6 +395,12 @@ jobs:
- os: windows-latest-64-cores
python-version: "3.11"
cloud-provider: azure
- os: windows-latest-64-cores
python-version: "3.12"
cloud-provider: aws
- os: windows-latest-64-cores
python-version: "3.12"
cloud-provider: azure
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"protobuf>=3.20, <6", # Snowpark IR
"tzlocal", # Snowpark IR
]
REQUIRED_PYTHON_VERSION = ">=3.8, <3.12"
REQUIRED_PYTHON_VERSION = ">=3.8, <3.13"

if os.getenv("SNOWFLAKE_IS_PYTHON_RUNTIME_TEST", False):
REQUIRED_PYTHON_VERSION = ">=3.8"
Expand Down
2 changes: 1 addition & 1 deletion tests/integ/test_packaging.py
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ def test_add_packages_with_native_dependency_without_force_push(session):
with pytest.raises(
RuntimeError, match="Your code depends on packages that contain native code"
):
session.add_packages(["catboost==1.2"])
session.add_packages(["catboost==1.2.3"])


@pytest.fixture(scope="function")
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ commands = coverage combine
coverage report -m
coverage xml -o {env:COV_REPORT_DIR:{toxworkdir}}/coverage.xml
coverage html -d {env:COV_REPORT_DIR:{toxworkdir}}/htmlcov --show-contexts
depends = py39, py310, py311
depends = py39, py310, py311, py312

[testenv:docs]
basepython = python3.9
Expand Down

0 comments on commit a0b35bd

Please sign in to comment.