SNOW-1331032 add retrieve func defaults from source #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-aalam
added
the
NO-CHANGELOG-UPDATES
7 tasks
sfc-gh-aalam
requested review from
sfc-gh-yixie,
sfc-gh-aling and
sfc-gh-yuwang
and removed request for
a team
sfc-gh-yuwang
requested changes
Jul 26, 2024
I added more tests. Just a note that the full PR has coverage satisfied: #1509 |
Base automatically changed from
aalam-SNOW-1331032-add-python-value-str-to-object
to
main
July 26, 2024 22:57
sfc-gh-yuwang
approved these changes
Jul 26, 2024
Comment on lines
+664
to
+671
| class {class_name}: | ||
| def {func_name}(self, x, y {datatype_str} = {annotated_value}) -> None: | ||
| return None | ||
| """ | ||
| else: | ||
| source = f""" | ||
| def {func_name}(x, y {datatype_str} = {annotated_value}) -> None: | ||
| return None |
There was a problem hiding this comment.
nit: have you tested multiple default values? def func(a, b=xx, c=xxx, g=xx)
it doesn't need to be complicated, but just testing multiple kwargs also works.
There was a problem hiding this comment.
I have it as an integration test over here: https://github.com/snowflakedb/snowpark-python/pull/1509/files#r1696077946
sfc-gh-aling
approved these changes
Jul 27, 2024
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
|
Seems like your changes contain some Local Testing changes, please request review from @snowflakedb/local-testing |
sfc-gh-aalam
deleted the
aalam-SNOW-1331032-add-retrieve_func_defaults_from_source
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1331032
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Splits original PR SNOW-1331032: Support default argument values in UDXF and SP #1509.
This PR adds a new function
retrieve_func_defaults_from_sourcewhich extracts default values from function registration when registrining sproc, udf, udtf from a file. The function is similar toretrieve_func_defaults_from_sourceand parses the AST of the given file to extract the default values.