Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1331032 Add function python_value_str_to_object #1954

Merged
merged 2 commits into from
Jul 26, 2024
Merged

SNOW-1331032 Add function python_value_str_to_object #1954

merged 2 commits into from
Jul 26, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Jul 22, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1331032

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  3. Please describe how your code solves the related issue.

    This PR breaks down SNOW-1331032: Support default argument values in UDXF and SP #1509.
    Follow-up PR is SNOW-1331032 add retrieve func defaults from source #1957

This PR adds function python_value_str_to_object which takes in a string and datatype from a python file and converts the string into a python object.

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 22, 2024
@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review July 22, 2024 22:04
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner July 22, 2024 22:04
@sfc-gh-aalam sfc-gh-aalam merged commit c3d30cd into main Jul 26, 2024
34 of 35 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-SNOW-1331032-add-python-value-str-to-object branch July 26, 2024 22:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-yuwang sfc-gh-yuwang sfc-gh-yuwang approved these changes

@sfc-gh-jdu sfc-gh-jdu sfc-gh-jdu approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aalam @sfc-gh-jdu @sfc-gh-yuwang