-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1665707: Move general.py into src/…/modin/plugin/extensions/ #2296
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to know what the real changes are in this version. Can we decouple this into smaller PRs?
Unfortunately, diff is doing a very bad job. Just look at the complete new file, and you'll find that now the methods/properties are following the same order as the pandas docs and their pandas categories are added as comments. |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1665707
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Move general.py into src/…/modin/plugin/extensions/. Also, re-organize the properties/methods in the file to match pandas documentation.