Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1665707: Move general.py into src/…/modin/plugin/extensions/ #2296

Merged
merged 15 commits into from
Sep 18, 2024

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1665707

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

    Move general.py into src/…/modin/plugin/extensions/. Also, re-organize the properties/methods in the file to match pandas documentation.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner September 16, 2024 17:47
@sfc-gh-helmeleegy sfc-gh-helmeleegy added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Sep 16, 2024
@sfc-gh-helmeleegy sfc-gh-helmeleegy marked this pull request as draft September 16, 2024 18:04
@sfc-gh-helmeleegy sfc-gh-helmeleegy marked this pull request as ready for review September 17, 2024 05:25
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard for me to know what the real changes are in this version. Can we decouple this into smaller PRs?

@sfc-gh-helmeleegy
Copy link
Contributor Author

It's hard for me to know what the real changes are in this version. Can we decouple this into smaller PRs?

Unfortunately, diff is doing a very bad job. Just look at the complete new file, and you'll find that now the methods/properties are following the same order as the pandas docs and their pandas categories are added as comments.

@sfc-gh-helmeleegy sfc-gh-helmeleegy enabled auto-merge (squash) September 17, 2024 20:02
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit f99a43e into main Sep 18, 2024
35 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1665707 branch September 18, 2024 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants