-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-876517: Test package auto-upload on Windows (V2) #976
Conversation
…NOW-871287-replicate-python-env # Conflicts: # tests/integ/test_packaging.py
…NOW-871287-replicate-python-env # Conflicts: # tests/integ/test_packaging.py
Codecov Report
@@ Coverage Diff @@
## main #976 +/- ##
==========================================
- Coverage 98.39% 98.36% -0.04%
==========================================
Files 51 51
Lines 9299 9277 -22
Branches 1692 1685 -7
==========================================
- Hits 9150 9125 -25
Misses 61 61
- Partials 88 91 +3
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# Conflicts: # src/snowflake/snowpark/_internal/packaging_utils.py # src/snowflake/snowpark/session.py # tests/integ/test_packaging.py
Intended to be merged after 1.6.0 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it correct to say that this just re-enables Windows test?
Yes, I was not confident enough in the fix for Windows to release these changes as part of 1.6.0 For reference, here is the Windows fix - #963 |
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.