Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-876517: Test package auto-upload on Windows (V2) #976

Merged
merged 279 commits into from
Aug 3, 2023

Conversation

sfc-gh-vnayak
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-vnayak sfc-gh-vnayak self-assigned this Jul 26, 2023
@sfc-gh-vnayak sfc-gh-vnayak added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 26, 2023
@sfc-gh-vnayak sfc-gh-vnayak changed the base branch from vnayak-SNOW-871287-replicate-python-env to main July 26, 2023 20:43
@sfc-gh-vnayak sfc-gh-vnayak changed the base branch from main to vnayak-SNOW-871287-replicate-python-env July 26, 2023 20:43
@sfc-gh-vnayak sfc-gh-vnayak changed the title SNOW-876517: Test package auto-upload on Windows SNOW-876517: Test package auto-upload on Windows (V2) Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #976 (161690d) into main (243bf10) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 161690d differs from pull request most recent head f04c8d0. Consider uploading reports for the commit f04c8d0 to get more accurate results

@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
- Coverage   98.39%   98.36%   -0.04%     
==========================================
  Files          51       51              
  Lines        9299     9277      -22     
  Branches     1692     1685       -7     
==========================================
- Hits         9150     9125      -25     
  Misses         61       61              
- Partials       88       91       +3     
Files Changed Coverage Δ
src/snowflake/snowpark/session.py 98.79% <ø> (+0.12%) ⬆️

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

# Conflicts:
#	src/snowflake/snowpark/_internal/packaging_utils.py
#	src/snowflake/snowpark/session.py
#	tests/integ/test_packaging.py
@sfc-gh-vnayak sfc-gh-vnayak changed the base branch from vnayak-SNOW-871287-replicate-python-env to main July 27, 2023 22:59
@sfc-gh-vnayak
Copy link
Contributor Author

Intended to be merged after 1.6.0 release

@sfc-gh-vnayak sfc-gh-vnayak marked this pull request as ready for review July 28, 2023 01:59
@sfc-gh-vnayak sfc-gh-vnayak requested a review from a team as a code owner July 28, 2023 01:59
Copy link
Collaborator

@sfc-gh-sfan sfc-gh-sfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct to say that this just re-enables Windows test?

@sfc-gh-vnayak
Copy link
Contributor Author

sfc-gh-vnayak commented Jul 28, 2023

Is it correct to say that this just re-enables Windows test?

Yes, I was not confident enough in the fix for Windows to release these changes as part of 1.6.0
By merging these changes after 1.6.0 is released, it gives the change some time to be baked in before the next release (1.7.0).

For reference, here is the Windows fix - #963

@sfc-gh-vnayak sfc-gh-vnayak merged commit 88ed7f9 into main Aug 3, 2023
40 checks passed
@sfc-gh-vnayak sfc-gh-vnayak deleted the vnayak-SNOW-876517-test-on-windows branch August 3, 2023 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants