Fix Pandas FutureWarning about integer indexing #1968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Github Issue SNOW-1552772: FutureWarning from Pandas about indexing in
mock._pandas_util
#1967Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Pandas prefers integer indexing with the
.iloc[]
accessor instead of implicitly assuming that an integer key is not a label but an index. It also issues aFutureWarning
that in the future also integer keys will be treated as labels and not as integer index, which will most likely cause an error when this behavior is implemented.The former code used either used
data[x]
instead ofdata.iloc[x]
or (maybe unintentionally)data.iloc[x][y]
instead ofdata.iloc[x, y]
and caused this warning.Not sure if an additional test is really necessary to check for warnings in the future, but I've added it anyway, please feel free to omit the test from the PR if you don't see it as necessary.