Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1458135 Implement DataFrame and Series initialization with lazy Index objects #2137
SNOW-1458135 Implement DataFrame and Series initialization with lazy Index objects #2137
Changes from 6 commits
2094c3f
97a7229
1979257
5dbb76d
7de467f
5dd06fd
8b94462
c89dc5d
a2089b8
a9376c1
420a5ac
66d634c
f277041
6a2cb79
df96f4a
f971b0d
13db956
8c78f8d
7970101
f3de1c3
2447022
82728bf
23587a4
1577ddc
8903f60
668c889
67a07c1
a4351ba
1453680
f39e751
b73f027
c6fc05d
d422f86
1ea5d00
024acd8
f4a80f3
ce1ffa6
00d2a8b
cb91849
d9fdbb0
3d5b785
7f9dbaa
6de9f49
c2fb474
2274d1e
9eef8d7
cc09403
10c3954
64dda24
da56734
8b47e17
fa4eb09
db28630
17be4c3
301f47f
2eb14a7
95065f7
d9bbd9b
f40c5b4
8cce409
f37b80a
83de657
57bf89c
8ed8e5b
cea97e0
03a68dc
19af4bb
1eb17dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If index_qc isn't supplied, does that mean the index of the new query compiler will be the default positional values?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it just means that the index will be whatever the index is for
self
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be helpful to clarify that in the docstring just so readers don't have to think about what "skip this join operation" means.