[Release-v1.22.0] Changes for prepare release v1.22.0 #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yzou
requested review from
sfc-gh-yixie,
sfc-gh-yuwang,
sfc-gh-jrose,
sfc-gh-mabrennan and
sfc-gh-mheavin
sfc-gh-yzou
commented
Sep 10, 2024
sfc-gh-yzou
commented
Sep 10, 2024
CHANGELOG.md
Outdated
| @@ -117,6 +117,7 @@ | |||
| - Display a clearer error message when `Index.names` is set to a non-like-like object. | |||
| - Raise a warning whenever MultiIndex values are pulled in locally. | |||
| - Improve warning message for `pd.read_snowflake` include the creation reason when temp table creation is triggered. | |||
| - When calling `DataFrame.set_index`, or setting `DataFrame.index` or `Series.index`, with a new index that does not match the current length of the `Series`/`DataFrame` object, a `ValueError` is no longer raised. When the `Series`/`DataFrame` object is longer than the new index, the `Series`/`DataFrame`'s new index is filled with `NaN` values for the "extra" elements. When the `Series`/`DataFrame` object is shorter than the new index, the extra values in the new index are ignored—`Series` and `DataFrame` stay the same length `n`, and use only the first `n` values of the new index. | |||
There was a problem hiding this comment.
@sfc-gh-azhan @sfc-gh-vbudati i am moving this from behavior change to improvement to avoid extra release process for behavior change.
There was a problem hiding this comment.
Can we make this a bit less verbose? For example the last sentence seems redundant. Also, is this the behavior of native pandas? If so, let's mention that at the beginning. For example:
Suggested change
| - When calling `DataFrame.set_index`, or setting `DataFrame.index` or `Series.index`, with a new index that does not match the current length of the `Series`/`DataFrame` object, a `ValueError` is no longer raised. When the `Series`/`DataFrame` object is longer than the new index, the `Series`/`DataFrame`'s new index is filled with `NaN` values for the "extra" elements. When the `Series`/`DataFrame` object is shorter than the new index, the extra values in the new index are ignored—`Series` and `DataFrame` stay the same length `n`, and use only the first `n` values of the new index. | |
| - Conform with the behavior of native pandas when calling `DataFrame.set_index`, or setting `DataFrame.index` or `Series.index` with a new index that does not match the current length of the `Series`/`DataFrame` object. A `ValueError` is no longer raised. Instead, when the `Series`/`DataFrame` object is longer than the provided index, the `Series`/`DataFrame`'s new index is filled with `NaN` values for the "extra" elements. When the `Series`/`DataFrame` object is shorter than the provided index, the extra values are ignored in the new index. |
There was a problem hiding this comment.
sure. the first sentence in the suggestion is not correct for the behavior since it actually diverge from the native pandas behavior, it is mainly for performance purpose to avoid eager evaluation. Updated it slightly differently
sfc-gh-vbudati
approved these changes
Sep 10, 2024
sfc-gh-azhan
approved these changes
Sep 10, 2024
sfc-gh-joshi
approved these changes
Sep 10, 2024
sfc-gh-nkrishna
approved these changes
Sep 10, 2024
sfc-gh-helmeleegy
approved these changes
Sep 11, 2024
CHANGELOG.md
Outdated
| @@ -117,6 +117,7 @@ | |||
| - Display a clearer error message when `Index.names` is set to a non-like-like object. | |||
There was a problem hiding this comment.
Display a clearer error -> Display a more clear error
sfc-gh-mabrennan
approved these changes
Sep 11, 2024
sfc-gh-yzou
added a commit
that referenced
this pull request
Sep 11, 2024
|
chagnes has cherry picked to main, close this pr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for release v1.22.0: