Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daily pre-commit tests #2604

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Fix daily pre-commit tests #2604

merged 1 commit into from
Nov 12, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review November 11, 2024 21:10
@sfc-gh-aalam sfc-gh-aalam requested a review from a team as a code owner November 11, 2024 21:10
@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Nov 11, 2024
@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) November 12, 2024 18:01
@sfc-gh-aalam sfc-gh-aalam merged commit f1e05f0 into main Nov 12, 2024
38 of 39 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-fix-daily-precommit branch November 12, 2024 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants