Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-v1.25.0] Changes for prepare release v1.25.0 #2616

Closed
wants to merge 6 commits into from
Closed

[Release-v1.25.0] Changes for prepare release v1.25.0 #2616

wants to merge 6 commits into from

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy commented Nov 12, 2024 •
edited by sfc-gh-aalam
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Update CHANGELOG, META.YAML and version.py

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

sfc-gh-aalam
sfc-gh-aalam reviewed Nov 13, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sfc-gh-azhan @sfc-gh-helmeleegy
SNOW-1491199 IR: Fix conda requirements (#2617)
e2a3fc1 
<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-1491199

2. Fill out the following pre-review checklist:

- [ ] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [ ] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://docs.google.com/document/d/162d_i4zZ2AfcGRXojj0jByt8EUq-DrSHPPnTa4QvwbA/edit#bookmark=id.e82u4nekq80k)

3. Please describe how your code solves the related issue.

Please write a short description of how your code change solves the
related issue.

Make sure build proto correctly in conda

https://ci-dev-142.int.snowflakecomputing.com/job/AnacondaPackageBuilder-x86/1574/
@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner November 14, 2024 01:30
sfc-gh-azhan and others added 2 commits November 14, 2024 09:51
@sfc-gh-azhan @sfc-gh-helmeleegy
SNOW-1491199 Fix publish job (#2629)
55efe9d 
<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

   <!---
   In this section, please add a Snowflake Jira issue number.

Note that if a corresponding GitHub issue exists, you should still
include
   the Snowflake Jira issue number. For example, for GitHub issue
#1400, you should
   add "SNOW-1335071" here.
    --->

   Fixes SNOW-NNNNNNN

2. Fill out the following pre-review checklist:

- [ ] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [ ] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://docs.google.com/document/d/162d_i4zZ2AfcGRXojj0jByt8EUq-DrSHPPnTa4QvwbA/edit#bookmark=id.e82u4nekq80k)

3. Please describe how your code solves the related issue.

Please write a short description of how your code change solves the
related issue.
@sfc-gh-aalam
fix python version
65581c7
@sfc-gh-helmeleegy sfc-gh-helmeleegy mentioned this pull request Nov 15, 2024
Merged
8 tasks
sfc-gh-helmeleegy added a commit that referenced this pull request Nov 15, 2024
@sfc-gh-helmeleegy
[CHERRY-PICK] Cherry-pick release note back to main (#2637)
b3be72d 
<!---
Please answer these questions before creating your pull request. Thanks!
--->

1. Which Jira issue is this PR addressing? Make sure that there is an
accompanying issue to your PR.

cherry-pick release note v1.25.0
#2616 back to main
   
2. Fill out the following pre-review checklist:

- [ ] I am adding a new automated test(s) to verify correctness of my
new code
- [ ] If this test skips Local Testing mode, I'm requesting review from
@snowflakedb/local-testing
   - [ ] I am adding new logging messages
   - [ ] I am adding a new telemetry message
   - [ ] I am adding new credentials
   - [ ] I am adding a new dependency
- [ ] If this is a new feature/behavior, I'm adding the Local Testing
parity changes.
- [x] I acknowledge that I have ensured my changes to be thread-safe.
Follow the link for more information: [Thread-safe Developer
Guidelines](https://docs.google.com/document/d/162d_i4zZ2AfcGRXojj0jByt8EUq-DrSHPPnTa4QvwbA/edit#bookmark=id.e82u4nekq80k)

3. Please describe how your code solves the related issue.

Please write a short description of how your code change solves the
related issue.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam left review comments

@sfc-gh-pspaeth sfc-gh-pspaeth sfc-gh-pspaeth approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-jkew sfc-gh-jkew Awaiting requested review from sfc-gh-jkew sfc-gh-jkew is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

Assignees

@sfc-gh-yuwang sfc-gh-yuwang

@sfc-gh-aalam sfc-gh-aalam

@sfc-gh-pspaeth sfc-gh-pspaeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sfc-gh-helmeleegy @sfc-gh-aalam @sfc-gh-jrose @sfc-gh-pspaeth @sfc-gh-yuwang @sfc-gh-azhan