Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1491199 IR: Fix conda requirements #2617

Merged
merged 1 commit into from
Nov 13, 2024
Merged

SNOW-1491199 IR: Fix conda requirements #2617

merged 1 commit into from
Nov 13, 2024

Conversation

sfc-gh-azhan
Copy link
Collaborator

@sfc-gh-azhan sfc-gh-azhan commented Nov 13, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1491199

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Make sure build proto correctly in conda
https://ci-dev-142.int.snowflakecomputing.com/job/AnacondaPackageBuilder-x86/1574/

@sfc-gh-azhan sfc-gh-azhan added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs labels Nov 13, 2024
@sfc-gh-azhan sfc-gh-azhan marked this pull request as ready for review November 13, 2024 15:59
@sfc-gh-azhan sfc-gh-azhan requested a review from a team as a code owner November 13, 2024 15:59
@sfc-gh-azhan sfc-gh-azhan enabled auto-merge (squash) November 13, 2024 15:59
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sfc-gh-azhan sfc-gh-azhan merged commit 8b6090a into main Nov 13, 2024
41 checks passed
@sfc-gh-azhan sfc-gh-azhan deleted the azhan-proto-conda-1491199 branch November 13, 2024 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-zyao sfc-gh-zyao Awaiting requested review from sfc-gh-zyao

@sfc-gh-oplaton sfc-gh-oplaton Awaiting requested review from sfc-gh-oplaton

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-azhan @sfc-gh-aalam @sfc-gh-helmeleegy