SNOW-1637215: Add describe query telemetry #2622
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jdu
added
the
NO-CHANGELOG-UPDATES
sfc-gh-jdu
requested review from
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-jrose
Comment on lines
+95
to
+99
| stack = traceback.extract_stack(limit=10)[:-1] | ||
| if len(stack) >= 2: | ||
| stack_trace = [frame.line for frame in stack] | ||
| else: | ||
| stack_trace = None |
There was a problem hiding this comment.
are we doing this to figure out which is the biggest contributor of describe queries?
sfc-gh-aalam
approved these changes
Nov 14, 2024
| TYPE_DESCRIBE_QUERY_DETAILS = "snowpark_describe_query_details" | ||
| SQL_TEXT = "sql_text" | ||
| E2E_TIME = "e2e_time" | ||
| STACK_TRACE = "stack_trace" |
There was a problem hiding this comment.
It's good that we're capturing the stack trace. But I imagine we'll need to further process it to extract the specific operations resulting in describe queries?
There was a problem hiding this comment.
yea, we can do the parsing on the dashboard side
sfc-gh-helmeleegy
approved these changes
Nov 15, 2024
sfc-gh-jdu
force-pushed
the
jdu-SNOW-1637215-describe-telemetry
branch
from
0ee4bda
to
56c7f03
Compare
sfc-gh-yzou
reviewed
Nov 16, 2024
| stack = traceback.extract_stack(limit=10)[:-1] | ||
| if len(stack) >= 2: | ||
| stack_trace = [frame.line for frame in stack] | ||
| else: |
There was a problem hiding this comment.
why when len(stack) < 2: the stack_trace is None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1637215
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Add telemetry for describe query mentioned in https://docs.google.com/document/d/1DAN1I99BQd1CBBu_pLvWb9vLReTC7HIbfppxeVbXCSg/edit?tab=t.0#heading=h.r285g4qcslsz