SNOW-1794355: [API Coverage] StructType #2623
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jrose
approved these changes
Nov 15, 2024
| @@ -11,6 +11,11 @@ | |||
| - `simple_string` | |||
| - `json_value` | |||
| - `json` | |||
| - Added support for method `from_json` in the following type classes: | |||
There was a problem hiding this comment.
we could possible combine all types related improvement summary in a common changelog.
Comment on lines
+677
to
+678
| _FIXED_DECIMAL = re.compile(r"decimal\(\s*(\d+)\s*,\s*(-?\d+)\s*\)") | ||
|
|
There was a problem hiding this comment.
Suggested change
| _FIXED_DECIMAL = re.compile(r"decimal\(\s*(\d+)\s*,\s*(-?\d+)\s*\)") | |
| _FIXED_DECIMAL = re.compile(r"decimal\(\s*(\d+)\s*,\s*(\d+)\s*\)") | |
we shouldn't be expecting negative numbers right?
| v.typeName(): v for v in _complex_types | ||
| } | ||
|
|
||
| _FIXED_DECIMAL = re.compile(r"decimal\(\s*(\d+)\s*,\s*(-?\d+)\s*\)") |
There was a problem hiding this comment.
Suggested change
| _FIXED_DECIMAL = re.compile(r"decimal\(\s*(\d+)\s*,\s*(-?\d+)\s*\)") | |
| _FIXED_DECIMAL_PATTERN = re.compile(r"decimal\(\s*(\d+)\s*,\s*(-?\d+)\s*\)") |
Comment on lines
+1362
to
+1365
| def test_structtype_from_json(tpe, json_dict, expected_result): | ||
| result = tpe.from_json(json_dict) | ||
| assert result == expected_result | ||
| assert isinstance(result, tpe) |
There was a problem hiding this comment.
I'm wondering if we can write some round-trip tests instead of re-writing a full set.
something like
datatype = MapType(IntegerType(), StringType())
json_value = datatype.jsonValue()
assert datatype == MapType.fromJson(json_value)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1794355
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.