Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1757439, SNOW-1757441: Support DataFrameGroupBy/SeriesGroupBy.pct_change #2625

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-joshi
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi commented Nov 14, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1757439, SNOW-1757441

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

This PR implements GroupBy.pct_change on top of the existing pct_change API.

Leaving changelog un-updated until 1.25 is cut/merged back.

@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi-SNOW-1757439-groupby-pct_change branch from 9cc7cdc to bef44c8 Compare November 14, 2024 19:47
@sfc-gh-joshi sfc-gh-joshi marked this pull request as ready for review November 14, 2024 20:49
@sfc-gh-joshi sfc-gh-joshi requested a review from a team as a code owner November 14, 2024 20:49
@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi-SNOW-1757439-groupby-pct_change branch from 8af07b0 to 04b63bd Compare November 14, 2024 22:46
@sfc-gh-joshi sfc-gh-joshi force-pushed the joshi-SNOW-1757439-groupby-pct_change branch from 04b63bd to bcc08e1 Compare November 15, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant