Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW: fix protoc dependency to fix python publish #2626

Merged
merged 1 commit into from
Nov 14, 2024
Merged

NO-SNOW: fix protoc dependency to fix python publish #2626

merged 1 commit into from
Nov 14, 2024

Conversation

sfc-gh-aalam
Copy link
Contributor

@sfc-gh-aalam sfc-gh-aalam commented Nov 14, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    Fix python publish job: https://github.com/snowflakedb/snowpark-python/actions/runs/11827990870/job/32957225738

@sfc-gh-aalam sfc-gh-aalam added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Nov 14, 2024
sfc-gh-helmeleegy
sfc-gh-helmeleegy approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-helmeleegy sfc-gh-helmeleegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sfc-gh-aalam sfc-gh-aalam marked this pull request as ready for review November 14, 2024 01:12
@sfc-gh-aalam sfc-gh-aalam requested review from a team as code owners November 14, 2024 01:12
@sfc-gh-aalam sfc-gh-aalam enabled auto-merge (squash) November 14, 2024 01:18
@sfc-gh-aalam sfc-gh-aalam merged commit f47f532 into main Nov 14, 2024
41 checks passed
@sfc-gh-aalam sfc-gh-aalam deleted the aalam-fix-python-publish branch November 14, 2024 01:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-helmeleegy sfc-gh-helmeleegy sfc-gh-helmeleegy approved these changes

@sfc-gh-azhan sfc-gh-azhan sfc-gh-azhan approved these changes

@sfc-gh-nkrishna sfc-gh-nkrishna Awaiting requested review from sfc-gh-nkrishna sfc-gh-nkrishna is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-joshi sfc-gh-joshi Awaiting requested review from sfc-gh-joshi sfc-gh-joshi is a code owner automatically assigned from snowflakedb/snowpark-pandas-api

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees

@sfc-gh-azhan sfc-gh-azhan

Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aalam @sfc-gh-azhan @sfc-gh-helmeleegy