Skip to content

Conversation

@vkcelik
Copy link

@vkcelik vkcelik commented Dec 13, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    We needed to use specific roles as secondary roles but this was not supported, so I added support for it. No Jira issue

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.
    The "USE SECONDARY ROLES" command has support for one or more specific roles but it was not supported in the use_secondary_roles method. This PR adds support for it.

@vkcelik vkcelik marked this pull request as ready for review December 13, 2024 13:34
@vkcelik vkcelik requested review from a team as code owners December 13, 2024 13:34
@vkcelik vkcelik changed the title Add support for list of specific roles as secondary roles Add support specific roles as secondary roles Dec 13, 2024
@vkcelik vkcelik changed the title Add support specific roles as secondary roles Add support for specific roles as secondary roles Dec 13, 2024
@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 24, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@vkcelik
Copy link
Author

vkcelik commented Mar 24, 2025

@sfc-gh-aalam @sfc-gh-smirzaei @sfc-gh-yixie
Hi I created this pull request long time ago but haven't received any response. Would any of you be able to look at it?

@sfc-gh-smirzaei sfc-gh-smirzaei removed their request for review July 22, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants