-
Notifications
You must be signed in to change notification settings - Fork 142
SNOW-2304052: hybrid execution tests on pre-commit #3778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sfc-gh-jkew
wants to merge
37
commits into
main
Choose a base branch
from
jkew/add-hybrid-precheck
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew/add-hybrid-precheck
…wpark-python into jkew/add-hybrid-precheck
…wpark-python into jkew/add-hybrid-precheck
…wpark-python into jkew/add-hybrid-precheck
…wpark-python into jkew/add-hybrid-precheck
…wpark-python into jkew/add-hybrid-precheck
Contributor
Author
|
Pulled this back into draft because I still have a smattering of random failures when running under hybrid mode in CI. |
…ew/add-hybrid-precheck
…wpark-python into jkew/add-hybrid-precheck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pre-commit tests for hybrid using a subset of known, fast ( < 0.25 s ) tests. This will help prevent regressions; but it represents around 26k tests normally written for push-down mode. These only execute on ubuntu-aws.
Some tests have been explicitly skipped with the @pytest.mark.skip_hybrid marker because they fail on CI but pass on local testing.
Fixes SNOW-2304052