-
Notifications
You must be signed in to change notification settings - Fork 142
Release v1.39.1 #3806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Release v1.39.1 #3806
Conversation
| def test_importing_plugin_always_turns_on_auto_switch_backend(): | ||
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend.""" | ||
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function name test_importing_plugin_always_turns_on_auto_switch_backend doesn't match the updated docstring which states that the plugin "always turns AutoSwitchBackend off". For consistency and clarity, consider renaming the function to test_importing_plugin_always_turns_off_auto_switch_backend to accurately reflect the behavior being tested.
| def test_importing_plugin_always_turns_on_auto_switch_backend(): | |
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend.""" | |
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off.""" | |
| def test_importing_plugin_always_turns_off_auto_switch_backend(): | |
| """Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off.""" | |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
| #### New Features | ||
| #### Bug Fixes | ||
|
|
||
| - Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo in the changelog entry: "genrated" should be "generated".
| - Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types. | |
| - Added an experimental fix for a bug in schema query generation that could cause invalid sql to be generated when using nested structured types. |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.