Skip to content

Conversation

@sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Comment on lines 6 to +7
def test_importing_plugin_always_turns_on_auto_switch_backend():
"""Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend."""
"""Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function name test_importing_plugin_always_turns_on_auto_switch_backend doesn't match the updated docstring which states that the plugin "always turns AutoSwitchBackend off". For consistency and clarity, consider renaming the function to test_importing_plugin_always_turns_off_auto_switch_backend to accurately reflect the behavior being tested.

Suggested change
def test_importing_plugin_always_turns_on_auto_switch_backend():
"""Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend."""
"""Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off."""
def test_importing_plugin_always_turns_off_auto_switch_backend():
"""Test that importing snowflake.snowpark.modin.plugin always turns AutoSwitchBackend off."""

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

#### New Features
#### Bug Fixes

- Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in the changelog entry: "genrated" should be "generated".

Suggested change
- Added an experimental fix for a bug in schema query generation that could cause invalid sql to be genrated when using nested structured types.
- Added an experimental fix for a bug in schema query generation that could cause invalid sql to be generated when using nested structured types.

Spotted by Diamond

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants