-
Notifications
You must be signed in to change notification settings - Fork 142
SNOW-2203826: Loosen flattening rules for sort and filter #3941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sfc-gh-yixie
wants to merge
14
commits into
main
Choose a base branch
from
yixie-SNOW-2203826-flatten-filter-sort
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+465
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nowflakedb/snowpark-python into yixie-SNOW-2203826-flatten-filter-sort
sfc-gh-jrose
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-2203826
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Snowpark currently is very strict in flattening the filter and sort clause when generating a query. For instance
df.select(col("c").alias("c1"), pow(2, "c").alias("d")).filter(col("c") > col("d"))doesn't work because the filter part is for a subquery, which is for the partdf.select(col("c").alias("c1"), pow(2, "c").alias("d")). So the filter doesn't work because the subquery doesn't have column c. If the query is flattened, then column c can be used to filter.sortis in a similar situation though different. This PR is to loosening the rules to flatten more cases while maintaining the correct logic.