Skip to content

Conversation

@sfc-gh-mayliu
Copy link
Collaborator

@sfc-gh-mayliu sfc-gh-mayliu commented Oct 29, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2268207

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-mayliu sfc-gh-mayliu requested a review from a team October 29, 2025 23:15
Comment on lines 163 to 165
Inner,
LeftOuter,
Cross,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know where these join types are documented? I checked our docs but couldn't find it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline with @sfc-gh-aling and @sfc-gh-qding. Though inner/left/cross join lateral usages are allowed in SQL execution, lateral_join() API will only support inner join lateral for now to prevent potential future BCR, until Snowflake doc explicitly documents other lateral join types' usages or upon user request. Current LATERAL source

@sfc-gh-mayliu sfc-gh-mayliu requested a review from a team November 4, 2025 01:12
@sfc-gh-mayliu sfc-gh-mayliu requested a review from a team November 4, 2025 23:42
@sfc-gh-mayliu sfc-gh-mayliu merged commit e37af77 into main Nov 7, 2025
28 of 29 checks passed
@sfc-gh-mayliu sfc-gh-mayliu deleted the SNOW-2268207-lateral-join branch November 7, 2025 20:58
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants