Skip to content

Conversation

@sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-2679277

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

    Add support for groupby.fillna/get_group/resample/rolling in faster pandas.

@sfc-gh-helmeleegy sfc-gh-helmeleegy requested a review from a team as a code owner November 5, 2025 19:16
@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Nov 5, 2025
@sfc-gh-helmeleegy sfc-gh-helmeleegy changed the title SNOW-2679277: Add support for groupby.fillna/get_group/resample/rolling in faster pandas SNOW-2679277: Add support for groupby.get_group/resample/rolling in faster pandas Nov 5, 2025
assert_series_equal(snow_result4, native_result4, check_dtype=False)


@pytest.mark.parametrize(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just moved with the rest of the groupby tests

assert_frame_equal(snow_result, native_result, check_dtype=False)


@pytest.mark.parametrize("property_name", ["groups", "indices"])
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also moved from below up here.

@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit d38d986 into main Nov 7, 2025
46 of 49 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-2679277 branch November 7, 2025 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants