Skip to content

SNOW-3120175 Change the way the Decimals are presented in _show_string_spark#4104

Open
sfc-gh-mbukalo wants to merge 3 commits intomainfrom
mbukalo/SNOW-3120175-change-decimal-string-transformation-
Open

SNOW-3120175 Change the way the Decimals are presented in _show_string_spark#4104
sfc-gh-mbukalo wants to merge 3 commits intomainfrom
mbukalo/SNOW-3120175-change-decimal-string-transformation-

Conversation

@sfc-gh-mbukalo
Copy link

@sfc-gh-mbukalo sfc-gh-mbukalo commented Mar 5, 2026

SNOW-3120175 Change the way the Decimals are presented in _show_string_spark

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3120175

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
    • If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
  3. Please describe how your code solves the related issue.

Change aims to display Decimal types which contain scientific notation in the same way as spark does. It shows the whole number instead of formatting with scientific notation as Snowflake does.

@github-actions
Copy link

github-actions bot commented Mar 5, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@sfc-gh-mbukalo
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-mbukalo sfc-gh-mbukalo marked this pull request as ready for review March 9, 2026 14:15
@sfc-gh-mbukalo sfc-gh-mbukalo requested review from a team as code owners March 9, 2026 14:15
reason="Local testing mock does not normalize Decimal scale to match DecimalType",
run=False,
)
def test_show_decimal_scientific_notation(session):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rewrite the test to be parametrized on input data/schema/expected output? It makes the code more concise, and ensures that one failing case won't mask failures from other cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants