Add health probe endpoint #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pondzix
reviewed
Oct 18, 2023
modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/Run.scala
Outdated
Show resolved
Hide resolved
pondzix
approved these changes
Oct 18, 2023
istreeter
force-pushed
the
feature/health-probe
branch
from
0016ea4
to
28130e4
Compare
istreeter
force-pushed
the
feature/health-probe
branch
from
28130e4
to
08665ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a http server so the deployment infrastructure (e.g. Kubernetes) can tell when the app is unhealthy.
In this first commit, we say the app is unhealthy only if there is an event which has been stuck for a long time, i.e. held in memory but not yet acked.
In follow-up commits, we can extend the
isHealthymethod to consider the health of other services too.