Release 0.2.2 #39
Merged
Release 0.2.2 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we used the `TIMESTAMP` column type. In Snowflake, this is _probably_ an alias for `TIMESTAMP_NTZ`, but actually it depends on whether the account owner has change the default of the `TIMESTAMP_TYPE_MAPPING` session parameter. We should pick a concrete timestamp type and use it explicitly for all new tables. This will prevent future confusion where we are not 100% sure what timestamp got used when creating the table. This change was supposed to happen in the first release, but it got overlooked.
Before this PR, the loader would crash immediately if the events table is missing a required column like `load_tstamp`. It is better if the loader stays alive long enough to send an informative message to the monitoring webhook.
Snowflake responds with a 4xx response code for various reasons when opening a channel: - User does not have permissions (403) - This table type does not support channels (400) - There are probably others I have not seen yet! Before this PR, if we treated the 403 as a setup error, but actually all 4xxs are probably setup errors. We should treat them gracefully by staying alive and sending an informative message to the monitoring webhook.
pondzix
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.