Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skipping schemas feature #6

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Nov 28, 2023

No description provided.

Copy link
Collaborator

@istreeter istreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@@ -92,6 +93,12 @@ object Config {
implicit val metricsDecoder = deriveConfiguredDecoder[Metrics]
implicit val healthProbeDecoder = deriveConfiguredDecoder[HealthProbe]
implicit val monitoringDecoder = deriveConfiguredDecoder[Monitoring]
implicit val schemaCriterionDecoder: Decoder[SchemaCriterion] =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for now... but it would be nice to move this into some library somewhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the library and I missed that! Changed the code to use decoder from iglu-core library

@pondzix pondzix merged commit 1347ead into common-libs-0.2.0 Nov 29, 2023
2 checks passed
@pondzix pondzix deleted the feature/skip_schemas branch November 29, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants