Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash app for Snowflake failures #9

Closed
wants to merge 3 commits into from
Closed

Don't crash app for Snowflake failures #9

wants to merge 3 commits into from

Conversation

pondzix
Copy link
Contributor

@pondzix pondzix commented Dec 4, 2023

No description provided.

@pondzix pondzix force-pushed the feature/retry_snowflake_failures branch 6 times, most recently from d2f9ef8 to 9e2bb85 Compare December 7, 2023 12:11
istreeter
istreeter approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@istreeter istreeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

modules/core/src/main/scala/com.snowplowanalytics.snowplow.snowflake/AppHealth.scala Outdated
Comment on lines 17 to 20
List(
latencyHealth(config, source),
snowflakeHealth.state.get
).sequence.map(_.combineAll)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you like...

  List(
    latencyHealth(config, source),
    snowflakeHealth.state.get
  ).foldA

link

...ore/src/main/scala/com.snowplowanalytics.snowplow.snowflake/processing/SnowflakeHealth.scala Outdated
}

object SnowflakeHealth {
private val unhealthy = HealthProbe.Unhealthy("Snowflake is not healthy")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose more strictly speaking our connection to Snowflake is not healthy.

@pondzix pondzix force-pushed the feature/retry_snowflake_failures branch from 9e2bb85 to 4d85da3 Compare December 7, 2023 13:19
@pondzix pondzix closed this Dec 7, 2023
@pondzix pondzix force-pushed the feature/retry_snowflake_failures branch from 4d85da3 to 16c180b Compare December 7, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@istreeter istreeter istreeter approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pondzix @istreeter @snowplowcla