Functions: Clean up webhooks

socialincome-san · Jan 24, 2025 · b8afaca · b8afaca
1 parent 7f0eac7
commit b8afaca
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 56 deletions.
diff --git a/admin/src/actions/CreateDonationCertificatesAction.tsx b/admin/src/actions/CreateDonationCertificatesAction.tsx
@@ -46,7 +46,7 @@ export function CreateDonationCertificatesAction({ selectionController }: Collec
 	const functions = getFunctions(undefined, DEFAULT_REGION);
 	const createDonationCertificatesFunction = httpsCallable<CreateDonationCertificatesProps, string>(
 		functions,
-		'createDonationCertificates',
+		'webhookCreateDonationCertificates',
 	);
 
 	const onClick = () => {

diff --git a/admin/src/actions/CreatePaymentForecastAction.tsx b/admin/src/actions/CreatePaymentForecastAction.tsx
@@ -7,7 +7,7 @@ export function CreatePaymentForecastAction() {
 	const snackbarController = useSnackbarController();
 
 	const createPaymentForecast = () => {
-		const runPaymentForecastTask = httpsCallable(getFunctions(undefined, DEFAULT_REGION), 'runPaymentForecastTask');
+		const runPaymentForecastTask = httpsCallable(getFunctions(undefined, DEFAULT_REGION), 'webhookPaymentForecastTask');
 		runPaymentForecastTask()
 			.then((result) => {
 				snackbarController.open({ type: 'success', message: 'Payment forecast updated successfully' });

diff --git a/admin/src/actions/PaymentProcessAction.tsx b/admin/src/actions/PaymentProcessAction.tsx
@@ -36,7 +36,7 @@ export function PaymentProcessAction() {
 	const triggerFirebaseFunction = (task: PaymentProcessTaskType) => {
 		const runPaymentProcessTask = httpsCallable<PaymentProcessProps, string>(
 			getFunctions(undefined, DEFAULT_REGION),
-			'runPaymentProcessTask',
+			'webhookPaymentProcessTask',
 		);
 		setIsFunctionRunning(true);
 		runPaymentProcessTask({

diff --git a/admin/src/views/ScriptsView.tsx b/admin/src/views/ScriptsView.tsx
@@ -11,7 +11,7 @@ export function ScriptsView() {
 			type: 'success',
 			message: 'Starting import',
 		});
-		httpsCallable(functions, 'batchImportStripeCharges')()
+		httpsCallable(functions, 'webhookBatchImportStripeCharges')()
 			.then(() => {
 				snackbarController.open({
 					type: 'success',
@@ -32,7 +32,7 @@ export function ScriptsView() {
 			type: 'success',
 			message: 'Starting creating surveys',
 		});
-		httpsCallable(functions, 'createAllSurveys')()
+		httpsCallable(functions, 'webhookCreateAllSurveys')()
 			.then(() => {
 				snackbarController.open({
 					type: 'success',
@@ -53,7 +53,7 @@ export function ScriptsView() {
 			type: 'success',
 			message: 'Starting adding amount_chf',
 		});
-		httpsCallable(functions, 'addMissingAmountChf')()
+		httpsCallable(functions, 'webhookAddMissingAmountChf')()
 			.then(() => {
 				snackbarController.open({
 					type: 'success',

diff --git a/functions/src/functions/webhooks/index.ts b/functions/src/functions/webhooks/index.ts
@@ -7,7 +7,6 @@ import {
 	createAllSurveysFunction,
 } from './admin/scripts';
 import stripeWebhookFunction from './stripe';
-import surveyLoginFunction from './website/survey-login';
 
 export const webhookPaymentProcessTask = paymentProcessFunction;
 export const webhookPaymentForecastTask = paymentForecastFunction;
@@ -18,6 +17,5 @@ export const webhookCreateAllSurveys = createAllSurveysFunction;
 
 // Do not rename this function, it is used by the Stripe webhook.
 export const webhookStripeCharge = stripeWebhookFunction;
-export const webhookSurveyCredentials = surveyLoginFunction;
 
 export const webhookCreateDonationCertificates = createDonationCertificatesFunction;
diff --git a/functions/src/functions/webhooks/website/survey-login/index.ts b/functions/src/functions/webhooks/website/survey-login/index.ts
diff --git a/shared/src/types/survey.ts b/shared/src/types/survey.ts
@@ -48,21 +48,8 @@ export const recipientSurveys = [
 	{ name: 'offboarded-checkin-4', startDateOffsetMonths: 72, questionaire: SurveyQuestionnaire.OffboardedCheckin },
 ];
 
-export interface SurveyCredentialRequest {
-	phoneNumber: string;
-	accessToken: string;
-}
-
-export interface SurveyCredentialResponse {
-	recipientId: string;
-	surveyId: string;
-	email: string;
-	pw: string;
-}
-
 export const getSurveyUrl = (baseUrl: string, survey: Survey, surveyId: string, recipientId: string) => {
 	const url = new URL([baseUrl, 'survey', recipientId, surveyId].join('/'));
-	const getParams = { email: survey.access_email, pw: survey.access_pw };
-	url.search = new URLSearchParams(getParams).toString();
+	url.search = new URLSearchParams({ email: survey.access_email, pw: survey.access_pw }).toString();
 	return url.toString();
 };