Validate both Orange Money ID and mobile money phone number for recipients in CSV task

[mkue]

Summary by CodeRabbit

• Bug Fixes
  • Improved validation to ensure both Orange Money ID and phone number are provided for each recipient. Missing information now triggers a clear error message specifying the recipient affected.

[coderabbitai]

📝 Walkthrough

Walkthrough

The validation in the RegistrationCSVTask class was updated to require both om_uid and mobile_money_phone.phone fields for each recipient. If either is missing, an error is thrown specifying which recipient is affected. No other logic or exports were changed.

Changes

File Path	Change Summary
functions/src/functions/webhooks/admin/payment-process/tasks/RegistrationCSVTask.ts	Enhanced recipient validation to require both om_uid and nested mobile_money_phone.phone; improved error messages.

Sequence Diagram(s)

sequenceDiagram
    participant Admin
    participant RegistrationCSVTask
    participant Recipient

    Admin->>RegistrationCSVTask: run()
    loop For each Recipient
        RegistrationCSVTask->>Recipient: Check om_uid and mobile_money_phone.phone
        alt Missing field(s)
            RegistrationCSVTask-->>Admin: Throw error with recipient ID
        else All fields present
            RegistrationCSVTask->>RegistrationCSVTask: Continue processing
        end
    end
    RegistrationCSVTask-->>Admin: Complete processing

Loading

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a15b26 and 6b997ca.

📒 Files selected for processing (1)

• functions/src/functions/webhooks/admin/payment-process/tasks/RegistrationCSVTask.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• functions/src/functions/webhooks/admin/payment-process/tasks/RegistrationCSVTask.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: Test functions
• GitHub Check: Prettify
• GitHub Check: Security checks (typescript)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c4568c and 8a15b26.

📒 Files selected for processing (1)

• functions/src/functions/webhooks/admin/payment-process/tasks/RegistrationCSVTask.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: MDikkii
PR: socialincome-san/public#960
File: recipients_app/lib/data/datasource/remote/user_remote_data_source.dart:87-91
Timestamp: 2025-01-06T18:59:26.103Z
Learning: The `Recipient` model enforces a non-nullable `userId` property, so no null checks are necessary there.

functions/src/functions/webhooks/admin/payment-process/tasks/RegistrationCSVTask.ts (1)

Learnt from: MDikkii
PR: socialincome-san/public#960
File: recipients_app/lib/data/datasource/remote/user_remote_data_source.dart:87-91
Timestamp: 2025-01-06T18:59:26.103Z
Learning: The `Recipient` model enforces a non-nullable `userId` property, so no null checks are necessary there.

🔇 Additional comments (1)

functions/src/functions/webhooks/admin/payment-process/tasks/RegistrationCSVTask.ts (1)

15-15: Error message clarity is good.

The error message clearly identifies which recipient is problematic and what's missing.

[github-actions]

Visit the preview URL for this PR (updated for commit a6bdf75):

https://si-admin-staging--pr1182-michael-fix-registra-k5raub0d.web.app

_{(expires Thu, 24 Jul 2025 06:37:50 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: b7b0969384059dce6ea8fad1ee1d1737e54e6676}