Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct default socket path. Use native engine of StarScream #1483

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Use correct default socket path. Use native engine of StarScream #1483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Source/SocketIO/Engine/SocketEngine.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ open class SocketEngine: NSObject, WebSocketDelegate, URLSessionDelegate,
public private(set) var sid = ""

/// The path to engine.io.
public private(set) var socketPath = "/engine.io/"
public private(set) var socketPath = "/socket.io/"

/// The url for polling.
public private(set) var urlPolling = URL(string: "http://localhost/")!
Expand All @@ -114,7 +114,7 @@ open class SocketEngine: NSObject, WebSocketDelegate, URLSessionDelegate,
public private(set) var urlWebSocket = URL(string: "http://localhost/")!

/// When `false`, the WebSocket `stream` will be configured with the useCustomEngine `false`.
public private(set) var useCustomEngine = true
public private(set) var useCustomEngine = false

/// The version of engine.io being used. Default is three.
public private(set) var version: SocketIOVersion = .three
Expand Down Expand Up @@ -750,6 +750,8 @@ extension SocketEngine {
/// - event: WS Event
/// - _:
public func didReceive(event: Starscream.WebSocketEvent, client: Starscream.WebSocketClient) {
DefaultSocketLogger.Logger.log("didReceive \(event)", type: "SocketEngine")

switch event {
case let .connected(headers):
wsConnected = true
Expand Down