Skip to content

FIX make_synthetic_competing_weibull() with default parameters #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jovan-stojanovic
Copy link
Contributor

@jovan-stojanovic jovan-stojanovic commented Jul 3, 2024

Fix #64 and add appropriate tests.

@jovan-stojanovic jovan-stojanovic marked this pull request as draft July 3, 2024 14:23
@jovan-stojanovic jovan-stojanovic marked this pull request as ready for review July 3, 2024 14:55
Copy link
Collaborator

@juAlberge juAlberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

Copy link
Collaborator

@Vincent-Maladiere Vincent-Maladiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jovan-stojanovic! Took us a while 😅

@Vincent-Maladiere Vincent-Maladiere merged commit 82fe8cb into soda-inria:main Jan 14, 2025
9 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
…ers (#66)

* fix key error when return_X_y=False

* fix tests

---------

Co-authored-by: Vincent Maladiere <[email protected]> 82fe8cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make_synthetic_competing_weibull function returns error with default parameters
3 participants