WIP: Split ImageSequence into a reader per backend. #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
What's your opinion on splitting the two changes:
Then we can first fix the deps, and then break the API in 0.4 We could do all the import-checks inside |
| @@ -225,7 +265,7 @@ def filename_to_indices(filename, identifiers='tzc'): | |||
| return result | |||
|
|
|||
|
|
|||
| class ImageSequenceND(FramesSequenceND, ImageSequence): | |||
| class ImageSequenceND(FramesSequenceND, BaseImageSequence): | |||
There was a problem hiding this comment.
I think it makes sense to make this BaseImageSequenceND
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress. Just pushing so I don't lose or forget about this old work.