feat: Allow passing raw wgsl implementation to shell à la template literal #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
aleksanderkatan
requested review from
mhawryluk,
iwoplaza and
reczkok
and removed request for
mhawryluk
mhawryluk
requested changes
Apr 8, 2025
added 14 commits
April 8, 2025 14:33
mhawryluk
reviewed
Apr 10, 2025
apps/typegpu-docs/src/content/docs/fundamentals/functions/index.mdx
Outdated
Show resolved
Hide resolved
| createComputeFn( | ||
| shell, | ||
| options.workgroupSize, | ||
| implementation as Implementation, | ||
| stripTemplate(arg as Implementation | TemplateStringsArray, ...values), |
There was a problem hiding this comment.
Suggested change
| stripTemplate(arg as Implementation | TemplateStringsArray, ...values), | |
| stripTemplate(arg, ...values), |
and same for all the other functions. I believe arg parameter of the call function can be typed as Implementation | TemplateStringsArray in fragment and vertex too, but we should check
There was a problem hiding this comment.
I think we can replace those argument types with raw Implementation | TemplateStringsArray, however I think that our Implementation type needs tweaking. I failed to come up with something right now, so I created issue #1147
apps/typegpu-docs/src/content/examples/simulation/confetti/index.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.