fix: Fix pointer value assignment type conversion #1526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pkg.pr.new packages benchmark commit |
reczkok
requested review from
aleksanderkatan and
iwoplaza
and removed request for
aleksanderkatan
reczkok
commented
Jul 22, 2025
Comment on lines
+171
to
+174
| ? lhsExpr.dataType.type === 'ptr' | ||
| ? [lhsExpr.dataType.inner as AnyData] | ||
| : [lhsExpr.dataType as AnyData] | ||
| : undefined; |
There was a problem hiding this comment.
This was actually a significant bug that completely disabled the type conversion for logical and binary expressions.
const forcedType = expression[0] === NODE.assignmentExpr
? [lhsExpr.dataType as AnyData]
: [];There was a problem hiding this comment.
Passing an empty array to convertToCommonType as the forcedType parameter says that the converted types have to be one of the ones in the array - since it was empty conversions were disabled.
iwoplaza
reviewed
Jul 22, 2025
Co-authored-by: Iwo Plaza <[email protected]>
|
Should we add a warning (or maybe throw even)? console.warn(
'convertToCommonType was called with an empty restrictTo array, which prevents any conversions from being matched. If you want to allow all conversions, pass undefined instead. If this is intentional, consider calling the function conditionally, as the result will always be undefined.',
);We could also make an empty array act the same way as undefined since calling this function with no legal conversions makes little sense. |
iwoplaza
reviewed
Jul 23, 2025
apps/typegpu-docs/src/content/examples/simulation/fluid-with-atomics/index.ts
Outdated
Show resolved
Hide resolved
iwoplaza
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we always made the type conversion system pick the lhs type regardless of all rules which resulted in trying to create a reference for the rhs instead of dereferencing lhs.
Before:
After:
(I also removed the redundant whitespace before the newline in the resolution error, it was driving me crazy. My formatter kept stubbornly removing trailing whitespace in inline snapshots.)