Bug: Highlighting not working with embedded LiveViews #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuzekAlan
reviewed
Oct 16, 2025
assets/client/utils/meta.js
Outdated
|
|
||
| const observer = new MutationObserver((mutations) => { | ||
| mutations.forEach((mutation) => { | ||
| console.log('mutation'); |
assets/client/utils/meta.js
Outdated
Comment on lines
11
to
14
| if ( | ||
| mutation.type === 'attributes' && | ||
| mutation.attributeName === 'data-phx-root-id' | ||
| ) { |
There was a problem hiding this comment.
Nitpick: how about early return?
assets/client/utils/meta.js
Outdated
Comment on lines
18
to
28
| if (Object.keys(rootIDs).length >= liveViewElements.length) { | ||
| const rootSocketIDs = new Set(Object.values(rootIDs)); | ||
| rootSocketIDs.delete(mainID); | ||
|
|
||
| observer.disconnect(); | ||
|
|
||
| resolve({ | ||
| mainSocketID: mainID, | ||
| rootSocketIDs: [...rootSocketIDs], | ||
| }); | ||
| } |
There was a problem hiding this comment.
Could you please split it to a function and name it so that it will be easier to understand what is happening here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is that debugger connect to the client via websocket using single root socket id but when dealing with "embedded" LiveViews there is more than one.
Solution I came up with:
socket_idof regular LiveView (it's the only LiveView ontransport_pidthat is neitherembeddednornested)Also fixes #723